Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iam, app): implements poh stamp provider #75

Merged
merged 10 commits into from
May 18, 2022
Merged

feat(iam, app): implements poh stamp provider #75

merged 10 commits into from
May 18, 2022

Conversation

farque65
Copy link
Contributor

  • removes unused context functions from test context fixtures

[#3]

app/__tests__/components/ProviderCards/PohCard.test.tsx Outdated Show resolved Hide resolved
iam/src/providers/poh.ts Show resolved Hide resolved
@shavinac shavinac self-requested a review May 18, 2022 13:51
Previously, the IAM tests were relying on on-chain data and, therefore, needed the RPC_URL to run
tests.
 Since we don't rely on on-chain data anymore, we can remove the environment variable from
the test step.

 This also fixes the poh implementation to use the RPC_URL env variable instead of
being hard-coded to the mainnet variable. This matches the convention we are using elsewhere (ENS,
etc).

[#3]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants